🔒 Dependency Dashboard #14
Labels
No labels
dependabork
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Headscracher/dosh#14
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
🔒 Dependency Dashboard (2)
2 high
quick-xml 0.38.4 — Quadratic run time when checking a start tag for duplicate attribute names
BytesStart::attributes()returns anAttributesiterator which, by default(
with_checks(true)), rejects a start tag that repeats an attribute name. Foreach attribute yielded, the iterator compared the new name against every name
seen so far in the same tag using a linear scan, so a start tag with
Ndistinct attribute names cost
O(N²)byte comparisons. There was no bound onNother than the size of the buffered start tag.Impact
Any code that parses untrusted XML and iterates a start tag's attributes with
the default duplicate check enabled can be made to spend CPU time quadratic in
the number of attributes on a single tag. Because the check is pure computation
with no
.await/I/O, an I/O-based timeout on the consumer (for example a reador request timeout) cannot interrupt it while it runs.
Measured cost of a single start tag, release build:
The cost grows with the square of the attribute count, so a start tag of a few
tens of megabytes can stall a parsing thread for hours. No memory is exhausted
and the parser does not crash; the effect is CPU exhaustion on the thread doing
the parsing: a single crafted start tag can pin a CPU core for minutes to hours,
denying service to that worker. A deployment that places a wall-clock bound on
parsing, or confines it to a non-critical thread, may consider the availability
impact lower.
Affected code paths
BytesStart::attributes()/Attributesiterated with checks enabled (thedefault), and
BytesStart::try_get_attribute.NsReader, which resolves namespaces by iterating a tag's attributes and soreaches the same check internally.
Consumers that iterate attributes with
.attributes().with_checks(false)and donot use
NsReaderare not affected.This was reported as reachable by a remote, unauthenticated attacker in a
real-world RPKI relying party (NLnet Labs Routinator) via a crafted RRDP
snapshot.xml.Remediation
Upgrade to
quick-xml >= 0.41.0, where the duplicate check keeps the linearscan for start tags with a small number of attributes and switches to an
O(1)hash pre-filter above a threshold, making the whole tag
O(N). The reportedAttrError::Duplicatedpositions are unchanged.If upgrading is not possible and duplicate-name detection is not required,
disable it with
.attributes().with_checks(false)(this does not helpNsReaderconsumers, which have no equivalent opt-out before 0.41.0).affected
>=0.0.0-0 <0.41.0· found inCargo.lockhttps://crates.io/crates/quick-xml · https://rustsec.org/advisories/RUSTSEC-2026-0194.html · https://github.com/tafia/quick-xml/issues/969 · https://github.com/tafia/quick-xml/pull/971 · https://github.com/tafia/quick-xml/commit/07f3db8343cf152f5bc3483ef5b3164582489bea
quick-xml 0.38.4 — Unbounded namespace-declaration allocation in `NsReader` enables memory-exhaustion denial of service
NsReaderresolves namespaces by callingNamespaceResolver::pushfor everyStart/Emptyevent before the event is returned to the caller.pushiterated all
xmlns/xmlns:*attributes on the start tag and, for each one,appended the prefix bytes to an internal buffer and pushed a
NamespaceBinding(32 bytes on 64-bit) to an internal
Vec, with no upper bound on the number ofdeclarations.
Impact
A start tag with
Nnamespace declarations drove roughly3×the tag's bytesize in
NamespaceResolverheap, allocated insidequick-xmlbefore theNsReaderconsumer ever received the event and could inspect or reject it. Aconsumer that bounds its input size therefore still cannot bound this
allocation: an
M-byte start tag yields on the order of3 × Mbytes ofresolver heap the caller never sees.
On untrusted XML this lets a remote, unauthenticated attacker force large heap
allocations with a single start tag. With several
NsReaders runningconcurrently on independent inputs (a common server pattern), the allocations
stack and can exhaust process memory, causing the operating system to kill the
process (OOM). This was confirmed against a real-world RPKI relying party (NLnet
Labs Routinator), where concurrent RRDP validation workers parsing a crafted
snapshot.xmlexceeded the memory limit and the process was OOM-killed.Affected code paths
Consumers using
NsReader(which always callsNamespaceResolver::pushbeforeyielding
Start/Empty), or callingNamespaceResolver::pushdirectly. A plainReaderthat does not perform namespace resolution is not affected.Remediation
Upgrade to
quick-xml >= 0.41.0.NamespaceResolver::pushnow rejects a starttag that declares more than
DEFAULT_MAX_DECLARATIONS_PER_ELEMENT(256)namespace bindings, returning the new
NamespaceError::TooManyDeclarationsinstead of allocating without limit. The limit is configurable via
NamespaceResolver::set_max_declarations_per_element(useusize::MAXtorestore the previous unbounded behavior), and
NsReader::resolver_mut()isprovided to reach it.
There is no clean workaround for
NsReaderconsumers before 0.41.0, as theallocation happens inside the reader with no configuration knob to cap it.
affected
>=0.0.0-0 <0.41.0· found inCargo.lockhttps://crates.io/crates/quick-xml · https://rustsec.org/advisories/RUSTSEC-2026-0195.html · https://github.com/tafia/quick-xml/issues/970 · https://github.com/tafia/quick-xml/commit/7ca25266e94987210daa864889ab15c9332c8a2a
Scanned 1 lockfile(s) · 2026-08-27 23:04 UTC · dependabork